Code Change Request: GetIn and GetInMan eventhandlers should be able to return "Commander"

[Tankbuster 1747]

The Getin and GetInMan eventhandlers can't return commander. If the unit gets into the commander seat, both GetIn and GetInMan return "gunner".

 

Please can this command be improved.

 

I can understand that the GetIn command is quite old and perhaps not well maintained, but GetInMan is brand new. It's weird that such a recently crafted command is made with this shortcoming.

 

 

[bad benson 1733]

i think you should also post this inside the dev branch scripting discussion thread. https://forums.bistudio.com/topic/151099-scripting-discussion-dev-branch/page-47

[Tankbuster 1747]

Yes, good point. I wrote this late last night I'll put it there too. Thanks mate

[killzone_kid 1333]

Both EHs use the same engine method, the difference to what entity they are attached. Creating new method just for that would also mean maintaning 2 methods instead of 1 in the future when some changes added to the engine. It always goes down to a combination of cost vs benefit, priorities and available resources.

[Tankbuster 1747]

I wasn't suggesting creating two different methods. If they both use the same engine method, then make the engine method better.

[killzone_kid 1333]

I wasn't suggesting creating two different methods. If they both use the same engine method, then make the engine method better.

 

Changing old method will make it backward incompatible since some existing scripts might rely on word "turret" returned for commander turret. Besides you can detect if player is commander quite easily:

player isEqualTo commander objectParent player

[Tankbuster 1747]

 

Changing old method will make it backward incompatible since some existing scripts might rely on word "turret" returned for commander turret.

That's your best reason for not improving the commands?

[killzone_kid 1333]

That's your best reason for not improving the commands?

 

Backward incompatibilty is one of the major reasons why some changes are rejected. It is always considered how much problems this could cause vs how much improvement could be made and sometimes improvements win, but often not. I am not the one who decides these things and I could be wrong, so go ahead make a request.

[Tankbuster 1747]

Backward compatibility didn't stop BI changing the Ifrit classname TWICE back in the bad old days. :)

 

I'm not having a go at you killzone, really I'm not and I'm grateful for your input. I'll head off to the dev scripting discussion forum now and request a close for this.

[BohemiaBeck 305]

Thread closed and request of thread starter.