Raw logic converted into efficiency, can someone please help, my brain is mush?

[harold5187 10]

Can someone view the link below, and give me your thoughts on how I would make this more efficient?

The mission works sort of, for the most part, give or take the aspects that aren't working quite as planned...

(This saves me from having to retype everything over and over...)

http://www.armaholic.com/forums.php?m=posts&q=22864

Another problem with my mission is the markers of the in-game spawned (createunit) units, after awhile end up in the ocean not following the units they're supposed to be attached to...

My markers are pre-created on the map at mission-start, and called through a trigger, condition True, only activate one time; When condition is met, it executes the following file...

*Please refer to the main problem listed in the link above, and then all this will make sense. I have a feeling someone helps me solve the above problem, that this problem will

fizzle out on it's own.

Also: What's best to use, to get a group to move by script, to the position of another unit, e.g. EastG1 move (getpos WestSlot1), or should I use Domove? Seems that it works initially, but

after awhile they just stand still regardless of receiving a move order? Can't figure that out... Anyway, thankyou, and again, this is not the MAIN problem, just sideaffects of the problems

listed in the link above, if someone with experience in SQS, or even SQF can assist me here, my scripting isn't at the level I wish...

initUnitMkrs.sqs

? (!(isServer)):exit;

#MkrRestart

?(alive WestSlot1): "W1Mkr" setmarkerpos (getpos WestSlot1);
?(alive WestSlot2): "W2Mkr" setmarkerpos (getpos WestSlot2);
?(alive WestSlot3): "W3Mkr" setmarkerpos (getpos WestSlot3);
?(alive WestSlot4): "W4Mkr" setmarkerpos (getpos WestSlot4);
?(alive WestSlot5): "W5Mkr" setmarkerpos (getpos WestSlot5);
?(alive WestSlot6): "W6Mkr" setmarkerpos (getpos WestSlot6);
?(alive WestSlot7): "W7Mkr" setmarkerpos (getpos WestSlot7);
?(alive WestSlot8): "W8Mkr" setmarkerpos (getpos WestSlot8);
?(alive WestSlot9): "W9Mkr" setmarkerpos (getpos WestSlot9);
?(alive WestSlot10): "W10Mkr" setmarkerpos (getpos WestSlot10);

?(Grp1Done==1): "E101Mkr" setmarkerpos (getpos E101);
?(Grp1Done==1): "E102Mkr" setmarkerpos (getpos E102);
?(Grp1Done==1): "E103Mkr" setmarkerpos (getpos E103);
?(Grp1Done==1): "E104Mkr" setmarkerpos (getpos E104);
?(Grp1Done==1): "E105Mkr" setmarkerpos (getpos E105);
?(Grp1Done==1): "E106Mkr" setmarkerpos (getpos E106);
?(Grp1Done==1): "E107Mkr" setmarkerpos (getpos E107);
?(Grp1Done==1): "E108Mkr" setmarkerpos (getpos E108);
?(Grp1Done==1): "E109Mkr" setmarkerpos (getpos E109);
?(Grp1Done==1): "E110Mkr" setmarkerpos (getpos E110);
?(Grp1Done==1): "E111Mkr" setmarkerpos (getpos E111);
?(Grp1Done==1): "E112Mkr" setmarkerpos (getpos E112);
?(Grp1Done==1): "E113Mkr" setmarkerpos (getpos E113);
?(Grp1Done==1): "E114Mkr" setmarkerpos (getpos E114);
?(Grp1Done==1): "E115Mkr" setmarkerpos (getpos E115);
?(Grp1Done==1): "E116Mkr" setmarkerpos (getpos E116);

?(Grp2Done==1): "E201Mkr" setmarkerpos (getpos E201);
?(Grp2Done==1): "E202Mkr" setmarkerpos (getpos E202);
?(Grp2Done==1): "E203Mkr" setmarkerpos (getpos E203);
?(Grp2Done==1): "E204Mkr" setmarkerpos (getpos E204);
?(Grp2Done==1): "E205Mkr" setmarkerpos (getpos E205);
?(Grp2Done==1): "E206Mkr" setmarkerpos (getpos E206);
?(Grp2Done==1): "E207Mkr" setmarkerpos (getpos E207);
?(Grp2Done==1): "E208Mkr" setmarkerpos (getpos E208);
?(Grp2Done==1): "E209Mkr" setmarkerpos (getpos E209);
?(Grp2Done==1): "E210Mkr" setmarkerpos (getpos E210);

?(Grp3Done==1): "E301Mkr" setmarkerpos (getpos E301);
?(Grp3Done==1): "E302Mkr" setmarkerpos (getpos E302);
?(Grp3Done==1): "E303Mkr" setmarkerpos (getpos E303);
?(Grp3Done==1): "E304Mkr" setmarkerpos (getpos E304);
?(Grp3Done==1): "E305Mkr" setmarkerpos (getpos E305);
?(Grp3Done==1): "E306Mkr" setmarkerpos (getpos E306);

?(Grp4Done==1): "E401Mkr" setmarkerpos (getpos E401);
?(Grp4Done==1): "E402Mkr" setmarkerpos (getpos E402);
?(Grp4Done==1): "E403Mkr" setmarkerpos (getpos E403);
?(Grp4Done==1): "E404Mkr" setmarkerpos (getpos E404);
?(Grp4Done==1): "E405Mkr" setmarkerpos (getpos E405);
?(Grp4Done==1): "E406Mkr" setmarkerpos (getpos E406);

?(Grp5Done==1): "E501Mkr" setmarkerpos (getpos E501);
?(Grp5Done==1): "E502Mkr" setmarkerpos (getpos E502);
?(Grp5Done==1): "E503Mkr" setmarkerpos (getpos E503);
?(Grp5Done==1): "E504Mkr" setmarkerpos (getpos E504);
?(Grp5Done==1): "E505Mkr" setmarkerpos (getpos E505);
?(Grp5Done==1): "E506Mkr" setmarkerpos (getpos E506);

?(Grp6Done==1): "E601Mkr" setmarkerpos (getpos E601);
?(Grp6Done==1): "E602Mkr" setmarkerpos (getpos E602);
?(Grp6Done==1): "E603Mkr" setmarkerpos (getpos E603);
?(Grp6Done==1): "E604Mkr" setmarkerpos (getpos E604);
?(Grp6Done==1): "E605Mkr" setmarkerpos (getpos E605);
?(Grp6Done==1): "E606Mkr" setmarkerpos (getpos E606);

?(Grp7Done==1): "E701Mkr" setmarkerpos (getpos E701);
?(Grp7Done==1): "E702Mkr" setmarkerpos (getpos E702);
?(Grp7Done==1): "E703Mkr" setmarkerpos (getpos E703);
?(Grp7Done==1): "E704Mkr" setmarkerpos (getpos E704);
?(Grp7Done==1): "E705Mkr" setmarkerpos (getpos E705);
?(Grp7Done==1): "E706Mkr" setmarkerpos (getpos E706);

~0.5

goto "MkrRestart";

exit

Edited June 29, 2013 by harold5187
Discovered some missing code, and added it...

[samatra 85]

Oh man all these sqs scripts its like a hello from 2001, did you live under a rock for 10 years and switch to ArmA 3 right from Flashpoint? :) On a serious note, its pretty difficult to keep up with sqs, I would suggest you to rewrite your mission with sqf. I don't really know why you need to keep all these east units in separate public variables? Why SetVehicleVarName? Do all your clients really need them? Or only a server does something with them?